Progress indicator for Batch listing #1544
Conversation
bika/lims/content/analysisrequest.py
Outdated
| @@ -2473,7 +2473,7 @@ def getProgress(self): | |||
| """Returns the progress in percent of all analyses | |||
| """ | |||
| review_state = api.get_review_status(self) | |||
| if review_state == "published": | |||
| if review_state in ["published", "invalid"]: | |||
There was a problem hiding this comment.
Shall we consider the cancelled state as well as complete?
There was a problem hiding this comment.
I wouldn't. "invalid" status can only be achieved after sample gets verified or published (so all analyses have been completed). "cancelled" happens in earlier stages and I think is ok to let the user know the percentage of conpleteness when the sample was cancelled, rather than forcing 100%
There was a problem hiding this comment.
Please consider that progresses less than 100% indicate that some actions still have to be done, which is not the case for the cancelled samples.
In our case we cancel samples, when there is no more interest in them, so I would expect a 100% when all active samples are done.
I'm not sure what to do best with the "rejected" ones...
There was a problem hiding this comment.
I would agree with @grulisco to interpret all final states as 100% done. Reinstantiate e.g. cancelled Samples would anyhow correctly restore the progress to the actual state of the Analyses.
There was a problem hiding this comment.
If the criteria is that the progress indicates that no more actions are required (instead of the percentage of completed actions), then we should always apply a percentage of 100% to end-statuses, these being rejected, cancelled or published (invalid is a status that happens after publish/verified, so we always expect invalid to be 100% - we only added the status here to make the function a bit faster).
IMO, percentage of completeness fits better with the number of tasks/actions done over the number of expected tasks/actions: for me a 100% completed for a rejected or cancelled sample is not intuitive, but well, a matter of taste I guess. I'd say this confusion can only happen when you are listing Samples with filter "All" enabled (you'll never see rejected/cancelled samples when "Active"/"To be verified"/... filter is used).
Is ok to me if you feel is better the percentage to indicate if there are still actions to be done, but then I strongly suggest to apply same criteria for rejected.
There was a problem hiding this comment.
I'd say this confusion can only happen when you are listing Samples with filter "All" enabled (you'll never see
rejected/cancelledsamples when "Active"/"To be verified"/... filter is used).
Full ACK in samples listing, but we are listing batches here. So confusion will definitely happen.
This feature is useful as an overview on open batches only, because closed ones are always to be expected 100%.
I also agree with 100% for all end-status...
There was a problem hiding this comment.
The progress calculation in batches relies on the code from Sample, which means that both will behave consistently in the end. I'm going then to consider all final sample states as 100%, this will then make a batch 100% even when it contains cancelled/rejected/retracted samples next to some published ones.
Description of the issue/feature this PR addresses
This PR adds progress indicators in batch listings, similar to those in Samples listing.
Furthermore, it is now possible to sort the column on progress.
Please merge senaite/senaite.app.listing#24 first
Current behavior before PR
Desired behavior after PR is merged
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.