Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency to plone.app.iterate #1551

Merged
merged 4 commits into from
Feb 19, 2020
Merged

Removed dependency to plone.app.iterate #1551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1d703f
Removed dependency to plone.app.iterate
ramonski Feb 18, 2020
df974ae
Added link to PR
ramonski Feb 18, 2020
61f7aa6
Changelog updated
ramonski Feb 18, 2020
814551e
Merge branch 'master' into remove-plone-app-iterate
xispa Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ Changelog

**Removed**

- #1551 Removed dependency to plone.app.iterate
- #1530 Removed ARImport
- #1530 Removed stale type registrations
- #1541 Remove add/edit options of ReferenceWidget
Expand Down
1 change: 0 additions & 1 deletion bika/lims/profiles/default/metadata.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<dependency>profile-jarn.jsi18n:default</dependency>
<dependency>profile-Products.ATExtensions:default</dependency>
<dependency>profile-Products.CMFEditions:CMFEditions</dependency>
<dependency>profile-plone.app.iterate:plone.app.iterate</dependency>
<dependency>profile-Products.TinyMCE:TinyMCE</dependency>
<dependency>profile-collective.js.jqueryui:default</dependency>
<dependency>profile-Products.DataGridField:default</dependency>
Expand Down
14 changes: 14 additions & 0 deletions bika/lims/upgrade/v01_03_003.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,9 @@ def upgrade(tool):
# Add progress metadata column for Batches
add_metadata(portal, BIKA_CATALOG, "getProgress", True)

# https://github.com/senaite/senaite.core/pull/1551
uninstall_plone_app_iterate(portal)

# Remove stale skin layers from portal_skins
# https://github.com/senaite/senaite.core/pull/1547
remove_skin_layers(portal)
Expand Down Expand Up @@ -916,6 +919,17 @@ def remove_arimports(portal):
logger.info("Removing AR Imports folder [DONE]")


def uninstall_plone_app_iterate(portal):
"""Uninstall plone.app.iterate
"""
qi = api.get_tool("portal_quickinstaller")
profile = "plone.app.iterate"
if qi.isProductInstalled(profile):
logger.info("Uninstalling '{}' ...".format(profile))
qi.uninstallProducts(products=[profile])
logger.info("Uninstalling '{}' [DONE]".format(profile))


def remove_skin_layers(portal):
"""Remove registered skin layers from portal_skins tool
"""
Expand Down