Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traceback in services listing in ARTemplate view #1583

Merged
merged 2 commits into from
May 14, 2020
Merged

Fix traceback in services listing in ARTemplate view #1583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06a8007
Fix traceback in analyses listing from ARTemplate view
xispa May 13, 2020
bcfec45
Changelog
xispa May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Changelog

**Fixed**

- #1583 Fix traceback in services listing in ARTemplate view
- #1581 Fix Some values are not properly rendered in services listing
- #1580 Fix Analysts are not displayed once created in worksheets listing
- #1575 Fix Uncertainties are displayed although result is below Detection Limit
Expand Down
4 changes: 3 additions & 1 deletion bika/lims/browser/widgets/artemplateanalyseswidget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,12 +230,14 @@ def folderitem(self, obj, item, index):
item["replace"]["Title"] = get_link(url, value=title)
item["Price"] = self.format_price(obj.Price)
item["allow_edit"] = self.get_editable_columns()
item["required"].append("Partition")
item["choices"]["Partition"] = self.partition_choices
item["Partition"] = partition
item["Hidden"] = hidden
item["selected"] = uid in self.configuration

# Make partition a required field
item.setdefault("required", []).append("Partition")

# Add methods
methods = obj.getMethods()
if methods:
Expand Down