Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Analysis Specs: Lookup dynamic specs only when specification is set and hide spec compliance viewlets #1588

Merged
merged 7 commits into from
Jun 9, 2020

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Jun 9, 2020

Description of the issue/feature this PR addresses

This PR caches the lookup for dynamic analysis specs and hides the compliance viewlets when a dynamic analysis specification is assigned.

Current behavior before PR

  • Results range repeated multiple times
  • Compliance viewlets complain about changed specifications

Desired behavior after PR is merged

  • Results range lookup cached per analysis
  • No specification compliance viewlets are displayed when a dynamic analysisspecifcation is used

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski changed the title Dynamic Analysis Specs: Cache range lookups and hide spec compliance viewlets Dynamic Analysis Specs: Lookup dynamic specs only when specification is set and hide spec compliance viewlets Jun 9, 2020
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xispa xispa merged commit d63883a into master Jun 9, 2020
@xispa xispa deleted the dynamic-specs-cache-and-viewlets branch June 9, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants