Fix for Report section displays date pickers in Chinese #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2020 10:47
xispa
requested changes
Oct 7, 2020
CHANGES.rst
Outdated
| @@ -10,6 +10,7 @@ Changelog | |||
| - #1628 Fix instrument import for analyses with result options | |||
| - #1625 Fix assignment of analyses via worksheet template when Worksheet is full | |||
| - #1617 Fix writing methods on read when reindexing services | |||
| - #1633 Fix report section displays date pickers in Chinese | |||
There was a problem hiding this comment.
@Espurna always add the changelog entry to the top of the list. They are always sorted from newest to oldest, as versions.
To all the reports. |
|
@Espurna I've done some cleanup. Can you confirm date pickers are working properly in your instance? |
|
@xispa After you changes, it is still working well. |
Some add-ons might use these datepicker_nofuture
xispa
approved these changes
Oct 8, 2020
xispa
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Linked issue: #1633
Current behavior before PR
Issue explained here: #1570
Desired behavior after PR is merged
"Date picker 2 months" in reports uses the proper language.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.