Allow to edit Profiles in Samples for pre verified/published states #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Oct 13, 2020
| setup.runImportStepFromProfile(profile, "typeinfo") | ||
| setup.runImportStepFromProfile(profile, "workflow") |
There was a problem hiding this comment.
You still need to keep setup.runImportStepFromProfile(profile, "workflow") because of #1620: workflow definitions for InterpretationTemplate and InterpretationTemplates are located in senaite.core profile.
| "to_be_sampled", | ||
| "sample_received", | ||
| "attachment_due", | ||
| "to_be_verified" |
There was a problem hiding this comment.
You missed a comma here, so the role mappings update do not apply to samples that are in "to_be_verified" or in "to_be_preserved" statuses.
xispa
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR allows to edit analysis profiles inside samples view.
Note: Adding a profile will add all contained samples, but removing a profile will retain added ones.
Current behavior before PR
Analysis profiles could be only added during sample registration (Add form)
Desired behavior after PR is merged
Analysis profiles can be added/removed in the sample view when the sample is in a non verified/published state.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.