Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply focus styling for setup view tiles when tabbing #1698

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Conversation

xispa
Copy link
Member

@xispa xispa commented Dec 1, 2020

Description of the issue/feature this PR addresses

Styling from setup views on focus do not change, making it not possible to know the tab with focus when using tabbing. This is specially important when the search bar is used and multiple items are found in the search

Current behavior before PR

Setup view tiles with focus do not have a different styling

Desired behavior after PR is merged

Setup view tiles with focus do not have a different styling

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski December 1, 2020 13:34
@ramonski ramonski merged commit ef38067 into 2.x Dec 1, 2020
@ramonski ramonski deleted the tab-setup-tile branch December 1, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants