Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Automatic verification of samples" setting in setup #1712

Merged
merged 1 commit into from
Dec 13, 2020

Conversation

xispa
Copy link
Member

@xispa xispa commented Dec 13, 2020

Description of the issue/feature this PR addresses

When the setting is enabled (default), the sample automatically transitions to verified status as soon as all the analyses it contains are verified. Manual verification of sample is required otherwise, once all analyses have been verified.

Some laboratories require these two verification processes (analyses and sample) to be independent.

Current behavior before PR

Sample is automatically verified as soon as the analyses it contains are verified

Desired behavior after PR is merged

Allow the user to choose whether the verification of samples must take place automatically or not

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

When the setting is enabled (default), the sample automatically
transitions to verified status as soon as all the analyses it
contains are verified. Manual verification of sample is
required otherwise, once all analyses have been verified.
@xispa xispa requested a review from ramonski December 13, 2020 13:33
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@ramonski ramonski merged commit 421190b into 2.x Dec 13, 2020
@ramonski ramonski deleted the auto-verify-samples branch December 13, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants