Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Controlpanel Items #1727

Merged
merged 5 commits into from
Jan 7, 2021
Merged

Cleanup Controlpanel Items #1727

merged 5 commits into from
Jan 7, 2021

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Jan 7, 2021

Description of the issue/feature this PR addresses

This PR unifies and cleans the code all control-panel listings and fixes missing column items

Current behavior before PR

Some listings had missing columns and used the old-style listing approach

Desired behavior after PR is merged

Listings provide all column items and use new-style listing approach

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski added Improvement 🔧 Cleanup 🧹 Code cleanup and refactoring labels Jan 7, 2021
@ramonski ramonski requested a review from xispa January 7, 2021 20:19
@xispa xispa merged commit 6ff9d3a into 2.x Jan 7, 2021
@xispa xispa deleted the cleanup-controlpanel-code branch January 7, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup 🧹 Code cleanup and refactoring Improvement 🔧
Development

Successfully merging this pull request may close these issues.

2 participants