Fix modified index is not reindexed when the object gets updated
#1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index `modified` does not get reindexed after an object is updated. It always store the value when the brain was created in first place.
ramonski
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
The index
modifieddoes not get reindexed after an object is updated. It always store the value when the brain was created in first place.This can be easily tested by transitioning a sample (e.g. cancel or invalidate) and then check with the jsonapi as follows:
http://localhost:9090/senaite/@@API/senaite/v1/analysisrequest?recent_modified=today
It might require #1808 to be merged first
Current behavior before PR
The
modifiedindex is not reindexed when the object gets updatedDesired behavior after PR is merged
The
modifiedindex is reindexed when the object gets updated--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.