Hide unit display after fields in manage analyses listing #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR fixes a display in sample manage analyses view that showed the unit after each input field.
The issue is actually located in
senaite.app.listing:https://github.com/senaite/senaite.app.listing/blob/2.x/webpack/app/components/TableCell.coffee#L447
this code displays always the unit after an editable field when a folderitem contains a key
Unit.Current behavior before PR
Unit displayed after each editable field in sample manage analyses view
Desired behavior after PR is merged
No unit displayed after each editable field in sample manage analyses view
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.