Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override datepicker's dateformat via locales #1830

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

xispa
Copy link
Member

@xispa xispa commented Jul 28, 2021

Description of the issue/feature this PR addresses

This Pull Request ensures that the date_format of datepickers is rendered in accordance with a custom "senaite.core.po" locale that overwrites the default one. To overwrite core locales with a custom one, plone.recipe.zope2instance has been used: https://github.com/plone/plone.recipe.zope2instance#locales

Current behavior before PR

Cannot overwrite the date_format for datepickers set by default in core's locales

Desired behavior after PR is merged

Can overwrite the date_format for datepickers set by default in core's locales

Screenshots

Captura de 2021-07-28 14-04-00

Captura de 2021-07-28 14-04-11

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski July 28, 2021 12:06
@ramonski ramonski merged commit 5b660b3 into 2.x Jul 28, 2021
@ramonski ramonski deleted the date-format-date-picker branch July 28, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants