Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an 'extra_inline_buttons' metal slot on edit macro #1833

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

xispa
Copy link
Member

@xispa xispa commented Aug 11, 2021

Description of the issue/feature this PR addresses

This Pull Request adds an extra slot for buttons that have to be displayed inline in the edit macro, next to those that already exist by default. With this extra_inline_buttons slots, the following is possible without having to overwrite default buttons slot.

Captura de 2021-08-11 16-47-46

Current behavior before PR

There is an extra_buttons slot, but is rendered below default buttons

Desired behavior after PR is merged

There is an extra_inline_buttons slot that is rendered next to default buttons

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski August 11, 2021 14:52
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@ramonski ramonski merged commit 6e33906 into 2.x Aug 12, 2021
@ramonski ramonski deleted the extra-inline-buttons branch August 12, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants