NDEV-41 After verification, department managers are not updated in results report anymore #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Jul 24, 2017
| # elements which are in either of the sets A or B but not in both. | ||
| are_differenet = saved_managers_ids.symmetric_difference( | ||
| current_managers_ids) | ||
| if data and len(are_differenet) == 0: |
There was a problem hiding this comment.
I'd say this conditional if data should be placed in line 723, like this:
if not overwrite
# Prevent any error related with digest
data = ar.getDigest() if hasattr(ar, 'getDigest') else None
if data:
# Check if the department managers have changed since the
# verification:
saved_managers = data.get('managers', {})
....
if len(are_different) == 0:
....| current_managers]) | ||
| # The symmetric difference of two sets A and B is the set of | ||
| # elements which are in either of the sets A or B but not in both. | ||
| are_differenet = saved_managers_ids.symmetric_difference( |
bika/lims/content/analysisrequest.py
Outdated
| @@ -1852,6 +1851,8 @@ def _getAnalysesNum(self): | |||
| total += 1 | |||
| return verified,total | |||
|
|
|||
| security.declareProtected(View, 'getResponsible') | |||
|
|
|||
There was a problem hiding this comment.
Not important, but better use @security.public decorator instead of security.declareProtected. Clener and easier to remember.
Example: https://github.com/naralabs/bika.lims/blob/wip/bika/lims/content/analysis.py#L27
bika/lims/content/analysisrequest.py
Outdated
| @@ -1888,7 +1889,7 @@ def getResponsible(self): | |||
|
|
|||
| return mngr_info | |||
|
|
|||
| security.declareProtected(View, 'getResponsible') | |||
| security.declareProtected(View, 'getManagers') | |||
xispa
changed the title
Ruhanga
pushed a commit
to Ruhanga/senaite.core
that referenced
this pull request
Mar 14, 2022
…ite#187) * Allow to introduce the Age instead of Date of Birth for Patient This commit makes the field Age from Patient Add/Edit form to be visible and editable when the option "Estimated Date of Birth" is checked, while "Birth Date" field remains hidden. User can then introduce the age in years, months and days and the date of birth is then calculated automatically (not accurate). When the option "Estimated Date of Birth" is unchecked, the age fields become hidden, while the "Birth Date" becomes visible for user input. * Age splitted is empty in Patient edit form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.