Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup for dependent analysis in partitions #1871

Merged
merged 4 commits into from
Nov 10, 2021
Merged

Conversation

toropok
Copy link
Contributor

@toropok toropok commented Nov 6, 2021

Let calculations work in case dependent analysis assigned to the subsample (partition)

Description of the issue/feature this PR addresses

Linked issue: #1870

Current behavior before PR

If calculation relies on the analysis assigned to subsample (partition) - it's not being calculated.

Desired behavior after PR is merged

That makes sense for complex calculations to have access to the results of tests in subsamples.

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

Let calculations work in case dependent analysis assigned to the subsample (partition)
Update ARAnalysesFieldWithPartitions.rst
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @toropok! Many thanks for fixing this!

@ramonski ramonski merged commit c11bf1f into senaite:2.x Nov 10, 2021
@toropok toropok deleted the patch-3 branch May 26, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants