Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable native form validation in header table #1895

Merged
merged 2 commits into from
Dec 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Changelog
2.0.1 (unreleased)
------------------

- #1895 Disable native form validation in header table
- #1893 Removed unused field PasswordLifeTime
- #1892 Drop jQuery Datepicker for HTML5 native date fields
- #1886 Use the current timestamp instead of the client name for report archive download
Expand Down
11 changes: 10 additions & 1 deletion src/bika/lims/browser/templates/header_table.pt
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,16 @@
sublists python:dummy[1];
errors python:request.get('errors',{})"
tal:condition="sublists">
<form method="post" name="header_form">
<tal:comment condition="python:False">
<!--
Note: the `novalidate` attribute is needed to avoid browser validation
when e.g. the "expected sampling date" has passed and another value
wants to be changed.

https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Constraint_validation
-->
</tal:comment>
<form novalidate method="post" name="header_form">
<input type="hidden" name="header_table_submitted" value="1" />

<table class="header_table table table-condensed table-bordered table-sm">
Expand Down