Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect/Multichoice support for interim fields #1979

Merged
merged 5 commits into from
Apr 25, 2022
Merged

Conversation

xispa
Copy link
Member

@xispa xispa commented Apr 25, 2022

Description of the issue/feature this PR addresses

This Pull Request adds the possibility to render multiselect/multichoice controls for interim fields

Please merge senaite/senaite.app.listing#72 first

Service's view edition of Results options:

Captura de 2022-04-25 10-12-42

Results entry for an analysis with interims of different control types:

Captura de 2022-04-25 10-51-15

View of an analysis with interims of different control types:

Captura de 2022-04-25 10-53-03

Current behavior before PR

The control rendered for interim fields with choices is always a (single) select control

Desired behavior after PR is merged

The control rendered for interim fields with choices depends on the interim's "Control type"

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski April 25, 2022 09:06
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! We should have an editor for those selection types. I always need to lookup the right format for testing...

@ramonski ramonski merged commit 61620fc into 2.x Apr 25, 2022
@ramonski ramonski deleted the interim-multi branch April 25, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants