NMRL-369 Sampling Date and Date Sampled fields are confusing #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show DateSampled instead of SamplingDate in productivity reports.
…-date-date-sampled-issues Conflicts: bika/lims/upgrade/configure.zcml bika/lims/upgrade/v3_2_0_1708.py
xispa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
Sampling Date is expected date that sample will be collected. It must be used only and only if Sampling Workflow is ENABLED from Bika Setup.
Date Sampled is the date that sample has actually been collected. Mandatory during creation of AR when Sampling Workflow is DISABLED, as well as when 'Sample' transaction is being run for a Sample or an AR if Sampling Workflow is enabled.
Every confusion in use of these fields has been fixed. For old Analysis Requests, which were created in Sampling Workflow disabled mode, 'Sampling Date' is actually 'DateSampled' and must be replaced (or copied) accordingly during upgrade step.