NDEV-60 Status inconsistences in Analyses in secondary Analysis Requests #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the funciton sample_set(arnum), the js calls to secondary_ar_sample_info and it returns a dictionary (data) with the default values that must be applied to the current Analysis Request. For some fields, there are duplicated keys for the same object (<fieldname>_uid and <fieldname>), so the values are not set correctly in the current state_set variable, causing that, for example, when the system tries to get the information of partitions based on the Sample Type, the system uses the SampleType name instead of its uid, making the system fail to return that partition information.
nihadness
reviewed
Aug 7, 2017
bika/lims/utils/analysisrequest.py
Outdated
| spartnum = int(spart.getId().split(prefix)[1]) | ||
| if spartnum > part_num: | ||
| part_num = spartnum | ||
|
|
||
| for n, partition in enumerate(partitions): | ||
| # Calculate partition id | ||
| partition_prefix = sample.getId() + "-P" |
There was a problem hiding this comment.
I think this line (110) is just a repeat of the line # 102 ? Should we take 102 out of if condition and delete this line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an Analysis Request is created by reusing a previously generated Sample (Secondary Analysis Request), the Analyses remains in "sample_registered". Their status should be "sample_due" if sampling workflow is enabled or "to_be_sampled" if the sampling workflow is disabled:
With this Pull Request, the function responsible of creating an Analysis Request based on the parameters set in the AR Add form checks if is a Secondary AR and in such case, the system tries to
With this PR, a bad behavior when trying to calculate the partitions for a given SampleType via ajax has been fixed. The system was trying to obtain a SampleType by using its title instead of the UID.