NDEV-69 Filters by Service, Category and Client do not work when adding Analyses into a Worksheet #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Aug 24, 2017
| @@ -43,14 +43,15 @@ | |||
| <input type="hidden" name="submitted" value="1"/> | |||
| <input tal:replace="structure context/@@authenticator/authenticator"/> | |||
| <label for="getWorksheetTemplate" i18n:translate="">Select template</label> | |||
| <select id="ProfileSelector" name="getWorksheetTemplate"> | |||
| <select id="ProfileSelector" name="getWorksheetTemplate" | |||
| tal:define="olist view/getWorksheetTemplates"> | |||
There was a problem hiding this comment.
Better to use a var name more meaningful, like ws_templates_list instead of olist
| @@ -66,44 +67,47 @@ | |||
| i18n:translate="">Category</label> | |||
| <select id="CategorySelector" | |||
| tal:attributes="name string:${form_id}_getCategoryTitle" | |||
| tal:define="olist view/getCategories" | |||
There was a problem hiding this comment.
Same here, better use categories_list instead of olist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user creates a Worksheet, the Add Analyses view is displayed. In this view, there is a bar that allows the user to filter the analyses to be included in the worksheet by several criteria: Analysis Service, Category and Client. Seems that once the Search button is pressed, the filter has no effect.
This issue has been resolved by getting the filter parameters and reloading the bikalisting javascript.
It also uses the vocabulary creator in order to fill the filter options.