Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Batch content type and remove getBatchUID index and column #2210

Closed
wants to merge 24 commits into from

Conversation

xispa
Copy link
Member

@xispa xispa commented Dec 29, 2022

Description of the issue/feature this PR addresses

Merge #2209 first

This Pull Request optimizes some functions from Batch content type and removes no longer needed indexes as well.

Current behavior before PR

Non-performant functions and unnecessary indexes and metadata columns related with Batch content type

Desired behavior after PR is merged

Better functions and unnecessary indexes and metadata columns are no longer present

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa added Cleanup 🧹 Code cleanup and refactoring Performance labels Dec 29, 2022
@xispa xispa marked this pull request as ready for review December 30, 2022 11:30
@xispa xispa requested a review from ramonski December 30, 2022 11:30
@xispa
Copy link
Member Author

xispa commented Dec 30, 2022

Close this one. Better to just search by BatchUID than keep back-references in Batch objects. Further info: #2219

@xispa xispa closed this Dec 30, 2022
@xispa xispa deleted the cleanup-batch-refs branch December 30, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup 🧹 Code cleanup and refactoring Performance
Development

Successfully merging this pull request may close these issues.

1 participant