Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Priority in Analyses Add View from Worksheet and allow to sort #232

Merged
merged 1 commit into from
Aug 28, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion bika/lims/browser/worksheet/views/add_analyses.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from Products.Five.browser.pagetemplatefile import ViewPageTemplateFile
from zope.interface import implements
from bika.lims.catalog import CATALOG_ANALYSIS_LISTING
from bika.lims.config import PRIORITIES
from bika.lims import bikaMessageFactory as _
from bika.lims import EditResults, EditWorksheet, ManageWorksheets
from bika.lims import PMF, logger
Expand Down Expand Up @@ -49,6 +50,10 @@ def __init__(self, context, request):
self.pagesize = 50

self.columns = {
'Priority': {
'title': '',
'sortable': True,
'index': 'getPrioritySortkey' },
'Client': {
'title': _('Client'),
'attr': 'getClientTitle',
Expand Down Expand Up @@ -82,7 +87,8 @@ def __init__(self, context, request):
'title': _('All'),
'contentFilter': {},
'transitions': [{'id':'assign'}, ],
'columns':['Client',
'columns':['Priority',
'Client',
'getClientOrderNumber',
'getRequestID',
'CategoryTitle',
Expand Down Expand Up @@ -211,6 +217,16 @@ def folderitem(self, obj, item, index):
t(_("Late Analysis")))
if self.hideclientlink:
del item['replace']['Client']
# Add Priority column
priority_sort_key = obj.getPrioritySortkey
if not priority_sort_key:
# Default priority is Medium = 3.
# The format of PrioritySortKey is <priority>.<created>
priority_sort_key = '3.%s' % obj.created.ISO8601()
priority = priority_sort_key.split('.')[0]
priority_text = PRIORITIES.getValue(priority)
priority_div = '<div class="priority-ico priority-%s"><span class="notext">%s</span><div>'
item['replace']['Priority'] = priority_div % (priority, priority_text)
return item

def getServices(self):
Expand Down
11 changes: 11 additions & 0 deletions bika/lims/content/abstractroutineanalysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,17 @@ def getDependencies(self):
dependencies.append(sibling)
return dependencies

@security.public
def getPrioritySortkey(self):
"""
Returns the key that will be used to sort the current Analysis
Delegates to getPrioritySortKey function from the AnalysisRequest
:return: string used for sorting
"""
analysis_request = self.getRequest()
if analysis_request:
return analysis_request.getPrioritySortkey()

@security.public
def setReflexAnalysisOf(self, analysis):
"""Sets the analysis that has been reflexed in order to create this
Expand Down
21 changes: 21 additions & 0 deletions bika/lims/content/analysisrequest.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
from bika.lims.browser.widgets import PrioritySelectionWidget
from bika.lims.browser.widgets import SelectionWidget
from bika.lims.browser.widgets import SelectionWidget as BikaSelectionWidget
from bika.lims.catalog import CATALOG_ANALYSIS_LISTING
from bika.lims.config import PROJECTNAME
from bika.lims.config import PRIORITIES
from bika.lims.content.bikaschema import BikaSchema
Expand Down Expand Up @@ -2963,6 +2964,7 @@ def getDateVerified(self):
"""
return getTransitionDate(self, 'verify', return_as_datetime=True)

@security.public
def getPrioritySortkey(self):
"""
Returns the key that will be used to sort the current Analysis Request
Expand All @@ -2974,6 +2976,25 @@ def getPrioritySortkey(self):
created_date = self.created().ISO8601()
return '%s.%s' % (priority, created_date)

@security.public
def setPriority(self, value):
if not value:
value = self.Schema().getField('Priority').getDefault(self)
self.Schema().getField('Priority').set(self, value)
self._reindexAnalyses(['getPrioritySortkey'], True)

@security.private
def _reindexAnalyses(self, idxs=None, update_metadata=False):
if not idxs and not update_metadata:
return
if not idxs:
idxs = []
analyses = self.getAnalyses()
catalog = getToolByName(self, CATALOG_ANALYSIS_LISTING)
for analysis in analyses:
analysis_obj = analysis.getObject()
catalog.reindexObject(analysis_obj, idxs=idxs, update_metadata=1)

def _getCreatorFullName(self):
"""
Returns the full name of this analysis request's creator.
Expand Down
3 changes: 3 additions & 0 deletions bika/lims/upgrade/v3_2_0_1708.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ def upgrade(tool):
# Add missing Priority Index and Column to AR Catalog
ut.addIndexAndColumn(CATALOG_ANALYSIS_REQUEST_LISTING,
'getPrioritySortkey', 'FieldIndex')
ut.addIndexAndColumn(CATALOG_ANALYSIS_LISTING,
'getPrioritySortkey', 'FieldIndex')

ut.refreshCatalogs()

logger.info("{0} upgraded to version {1}".format(product, version))
Expand Down