Progress bar column in Analysis Requests list and AnalysesNum revisited #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: bika/lims/skins/bika/ploneCustom.css.dtml
Traceback (innermost last): Module ZPublisher.Publish, line 138, in publish Module ZPublisher.mapply, line 77, in mapply Module ZPublisher.Publish, line 48, in call_object Module bika.lims.browser.worksheet.workflow, line 100, in __call__ Module bika.lims.browser.worksheet.workflow, line 263, in submit Module bika.lims.workflow, line 114, in doActionFor Module Products.CMFCore.WorkflowTool, line 241, in doActionFor Module Products.CMFCore.WorkflowTool, line 552, in _invokeWithNotification Module Products.DCWorkflow.DCWorkflow, line 282, in doActionFor Module Products.DCWorkflow.DCWorkflow, line 421, in _changeStateOf Module Products.DCWorkflow.DCWorkflow, line 531, in _executeTransition Module zope.event, line 31, in notify Module zope.component.event, line 24, in dispatch Module zope.component._api, line 136, in subscribers Module zope.component.registry, line 321, in subscribers Module zope.interface.adapter, line 585, in subscribers Module zope.component.event, line 32, in objectEventNotify Module zope.component._api, line 136, in subscribers Module zope.component.registry, line 321, in subscribers Module zope.interface.adapter, line 585, in subscribers Module bika.lims.workflow, line 252, in AfterTransitionEventHandler Module bika.lims, line 205, in wrapper Module bika.lims.content.referenceanalysis, line 175, in workflow_script_submit Module bika.lims, line 205, in wrapper Module bika.lims.content.abstractanalysis, line 1298, in workflow_script_submit Module bika.lims.workflow.analysis.events, line 26, in after_submit AttributeError: getRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the ComputedField
AnalysesNumfrom Analysis Request content type, cause it was only used for indexes and the counterpart function is enough. Added more indicators ingetAnalysesNumfunction, so now the function returns an array as follows:With this Pull Request, the Analysis Request object is reindexed (so
getAnalysesNumis re-indexed) after a transition to any analysis is performed.Although the "Number of Analyses" column hasn't been removed from Analysis Requests lists, this PR adds a new column that takes advantage of this information and makes easier for the user to know the current percentage of completeness of each Analysis Request: