NDEV-50 Sort on column or index is not valid #239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug/confusion in bika_listing's sorting algorithm.
We know that there is 'columns' dictionary in each listing view. Each item in that dictionary contains 'id' of the column and different options of that column.
One of the keys of column values is 'index' which must be used to sort folder items, if its column has chosen to be sorted on. It works properly when clicked on table headers to sort. However, when 'review_states' is changed, that 'sort_on' fails. Apparently, the reason underlies URL of 'review_state' buttons. The URLs should contain column ID where now they directly contain index ID.