Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMRL-399 ZeroDivisionError: integer division or modulo by zero when calculating progress #246

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

xispa
Copy link
Member

@xispa xispa commented Sep 5, 2017

This error was thrown in an Analysis Request list:

Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module bika.lims.browser.analysisrequest.analysisrequests, line 1114, in __call__
  Module bika.lims.browser.bika_listing, line 871, in __call__
  Module Products.Five.browser.pagetemplatefile, line 125, in __call__
  Module Products.Five.browser.pagetemplatefile, line 59, in __call__
  Module zope.pagetemplate.pagetemplate, line 132, in pt_render
  Module five.pt.engine, line 98, in __call__
  Module z3c.pt.pagetemplate, line 163, in render
  Module chameleon.zpt.template, line 289, in render
  Module chameleon.template, line 191, in render
  Module chameleon.template, line 171, in render
  Module 16ef82f28703d31bb8a931cb8bb83d3a.py, line 499, in render
  Module d3f52dd11125b8f9d626501acb25dc18.py, line 1172, in render_master
  Module d3f52dd11125b8f9d626501acb25dc18.py, line 484, in render_content
  Module 16ef82f28703d31bb8a931cb8bb83d3a.py, line 429, in __fill_content_core
  Module five.pt.expressions, line 161, in __call__
  Module bika.lims.browser.bika_listing, line 1332, in contents_table
  Module bika.lims.browser.bika_listing, line 1426, in __init__
  Module bika.health.browser.analysisrequests.view, line 44, in folderitems
  Module bika.lims.browser.analysisrequest.analysisrequests, line 804, in folderitems
  Module bika.lims.browser.bika_listing, line 1062, in folderitems
  Module bika.health.browser.analysisrequests.view, line 48, in folderitem
  Module bika.lims.browser.analysisrequest.analysisrequests, line 856, in folderitem
ZeroDivisionError: integer division or modulo by zero

An Analysis Request with no analyses assigned is presumably the root reason of this error. This Pull Request fixes the error, but a better solution to be considered is to not allow the removal of all analyses from a given Analysis Request (Manage Analyses view).

@xispa xispa requested a review from Espurna September 5, 2017 16:46
@Espurna Espurna merged commit 6441043 into wip Sep 5, 2017
@Espurna Espurna deleted the nmrl-399-division-by-zero branch September 5, 2017 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants