PR 2266 BikaListing. Instrument calibration table fixes #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a shim in front of InstrumentCertificationsView, which can easily be used directly.
rockfruit
force-pushed
the
integration-of-pr-2266
branch
from
7062f4c to
562619a
Compare
xispa
reviewed
Oct 23, 2017
| ] | ||
| self.allow_edit = False | ||
| self.show_select_column = False | ||
| self.show_workflow_action_buttons = False | ||
| self.show_workflow_action_buttons = True |
There was a problem hiding this comment.
Afak, there are no specific transitions available for Certifications (or at least, shouldn't be). Why the need of displaying the workflow action buttons bar?
There was a problem hiding this comment.
Indeed, good catch @xispa . I had to add this to display the bottom button bar where the "Show more" button lives.
There was a problem hiding this comment.
I see, it was just a required trick
xispa
changed the title
xispa
approved these changes
Oct 24, 2017
| ] | ||
| self.allow_edit = False | ||
| self.show_select_column = False | ||
| self.show_workflow_action_buttons = False | ||
| self.show_workflow_action_buttons = True |
There was a problem hiding this comment.
I see, it was just a required trick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Original PR: bikalims/bika.lims#2266
Linked issues:
Current behavior before PR
Desired behavior after PR is merged
Calibration listing table works as expected