Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR-1932: LIMS-2597: Fix AttributeError: bika_setup on login on a new Plone site w/o bika.lims installed (#1932) #298

Merged
merged 2 commits into from
Oct 25, 2017

Conversation

Espurna
Copy link

@Espurna Espurna commented Oct 24, 2017

Porting PR 1932 from bikalims

This PR includes:

  • An schemata modification in bika_setup
  • subscribers/configure.zcml better readability
  • dep_cookie.py better readability and fixing error if bikalims is not installed

This PR does not include:

  • portlet_department_filter.pt modifications since all errors were fixed in Naralabs branch.

Espurna added 2 commits October 24, 2017 16:05
This commit includes several things:
- An schemata modification in bika_setup
- subscribers/configure.zcml better readability
- dep_cookie.py better readability and fixing error if bikalims is not installed
@Espurna Espurna changed the title PR-1932: LIMS-2597: Fix AttributeError: bika_setup on login on a new Plone site w/o bika.lims installed #1932 PR-1932: LIMS-2597: Fix AttributeError: bika_setup on login on a new Plone site w/o bika.lims installed (#1932) Oct 24, 2017
@rockfruit rockfruit mentioned this pull request Oct 24, 2017
37 tasks
@xispa xispa requested a review from ramonski October 24, 2017 21:25
@xispa xispa added the Bug 🐞 label Oct 24, 2017
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ramonski ramonski merged commit 5c58d33 into senaite:senaite-integration Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants