PR-2205: Issue-2204: Conditional Email Notification on AR retract #2205 #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 26, 2017 15:18
|
Thanks Pau. For me it is at the moment just required that the whole Email notification on AR retract can be switched off for my customer. I didn't had yet the time to look into the retraction workflow, but I think this all can be hooked up in coming PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly ports https://github.com/bikalims/bika.lims/pull/2205/files , that con be itemized as follows:
WARNING: retraction workflow is not working, after talking with @rockfruit and @xispa about this we agreed with the following: Since this PR doesn't modifies the workflow, only adds a conditional and some new fields to bikasetup, and workflows will be ported later, we have decided to merge this work as it is.