PR2158 Stickers on listing plus autoprint generates PDF #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Print Stickers action to AR listings * Fixed bug that caused Print Stickers view to not popup * Updated changelog Conflicts: CHANGES.rst
ramonski
approved these changes
Oct 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of bikalims/bika.lims#2158 + autoprint displays the PDF instead of browser's print dialog.
With this Pull Request, the behavior of autoprint for stickers has changed. When
autoprint=1, a new browser tab with the pdf inline is displayed, while the original tab redirects to the previous page. So, if the user selects some Analysis Requests from AR list and presses the button "Pint stickers", a new tab will be displayed with the PDF inline, but the original tab goes back to the list of analysis requests.This behavior not only applies to "Print stickers" function for AR lists, but also in automatic stickers printing upon reception/submission.