-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accreditation Portlet renders an error message for anonymous users #336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good approach @nihadness. But please have a look at the source of plone.app.layout.globals.portal.PortalState
(here it is the @@plone_portal_state
view) and search for anonymous
. Then use that method with inverted logic.
However, we should delete this portlet in the future and setup a set of sane portlets during setup like here: https://github.com/senaite/senaite.lims/blob/master/src/senaite/lims/setuphandlers.py#L24
Looks better now, I guess :) |
plone_view context/@@plone;"> | ||
anonymous portal_state/anonymous; | ||
plone_view context/@@plone;" | ||
tal:condition="python: not anonymous"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could even skip the python
part in the condition and just write tal:condition="not:anonymous"
. But this is also fine;) well done
Current behavior
The accreditation portlet is rendered with an error message, for anonymous users.
Expected behavior after this PR
Accreditation Portlet is not being rendered for anonymous users.
For more detailed information, please see:#301