Fix TypeError: "Can't pickle objects in acquisition wrappers" (Calculation) #340
Conversation
bika/lims/browser/analyses.py
Outdated
| @@ -459,7 +459,7 @@ def folderitem(self, obj, item, index): | |||
| item['class']['retested'] = 'center' | |||
| item['result_captured'] = self.ulocalized_time( | |||
| obj.getResultCaptureDate, long_format=0) | |||
| item['calculation'] = obj.getCalculation and True or False | |||
| item['calculation'] = obj.getCalculationUID | |||
There was a problem hiding this comment.
Better change this line to obj.getCalculationUID and True or False so that it still contains a boolean type instead of an empty string '' or an UID '0666cd13ce844451b24f32ec8f5cd883'
There was a problem hiding this comment.
The value for this field is only used to check if the analysis requires calculation, so I thought there was any difference. In fact, I thought was better to set the UID, cause it would be used later with coffescript to get the calculation directly. But yes, you are right, will do the change
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0"?> | |||
| <metadata> | |||
| <version>1.1.0</version> | |||
| <version>1.1.2</version> | |||
| <dependencies> | |||
There was a problem hiding this comment.
Why the jump directly to 1.1.2 and not 1.1.1?
There was a problem hiding this comment.
I missed to set the metadata's version to 1.1.1 in my previous upgradestep :(
Fixes #322
The assignment of the whole Calculation object in a metadata column
getCalculationwas causing a "TypeError: Can't pickle objects in acquisition wrappers".With this Pull Request,
getCalculationmetadata column has been replaced bygetCalculationUIDinbika_analysis_catalog. This metadata field is only used in analyses listing to flag an analysis as it result needs to be calculated.I've done some functional testing and calculations in manage results view work as expected, also if old calculations are edited (generating new versions). Afak, tests for calculations were the only thing that was failing in #320 .
Requires upgrade step v1.1.2