Issue-351: Fix traceback on listings #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
changed the title
rockfruit
reviewed
Nov 5, 2017
| workflows = self.workflow.getWorkflowsFor(obj) | ||
| for wf in workflows: | ||
| if wf.state_var: | ||
| wf_state_var = wf.state_var |
There was a problem hiding this comment.
This is really nice! When we merge senaite-integration to master, most secondary workflows (notably cancellation and deactivation) will be removed, and review_state will be used to manage these states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Linked issue: #351
Current behavior before PR
Traceback on Listings where objects follow the
bika_inactive_workflowDesired behavior after PR is merged
Listings work for objects which follow a workflow that does not have the
review_statevariable--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.