Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let 'DateTimeField' setter accept datetime.datetime objects and convert them. #369

Merged
merged 4 commits into from
Nov 14, 2017
Merged

Let 'DateTimeField' setter accept datetime.datetime objects and convert them. #369

merged 4 commits into from
Nov 14, 2017

Conversation

nihadness
Copy link
Contributor

Current behavior
When sending datetime.datetime objects to the setter of DateTimeField, it raises a TypeError.

Expected behavior after this PR
DateTimeField set function accepts datetime.datetime objects, converts and saves the value.

@nihadness nihadness requested a review from rockfruit November 9, 2017 13:43
@rockfruit rockfruit merged commit 07f8427 into senaite:senaite-integration Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockfruit rockfruit Awaiting requested review from rockfruit

Assignees
No one assigned
Labels
Addition ➕
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nihadness @rockfruit