ID Server seeding function, flushed storage, utf-8 encoding, etc. #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added KeyError trap on GenerateUniqueId to provide more detail * Allow year in all portal types in ID Server config * Included a test for batch id with a year in it in IDServer * Improved ID Format description * Normalise new ID to exclude funny characters * Used normalise_filename because normalise_id does a lower() * Added portal type to number generator * Added seed setting browser view * Reformated IDFormattingField description * Added validation to seed function * Refactored generateUniqueId to use cleaner sub function * Refactored set_seed to set_number * Removed duplicate line of code * Added try/finally around set_number * Added validation to splitSliceJoin and doc tests * Fixed splitSpliceJion validation; added CopyError catch in renameAfterCreation * Add added normalize to number_generator key Added seed function to IDServer test * In idserver, use DateSampled instead of SamplingDate for Sample IDs * new_seq might be referenced before assignment * Some formatting and PEP8 * Some formatting and PEP8 * PEP8 only * Handle alredy taken IDs * Handle nonexisting SampleDate gracefully * Refactored ID server so both DateSampled and SamplingDate to be variables in the Sample ID * Removed unused import Conflicts: bika/lims/browser/configure.zcml bika/lims/content/bikasetup.py bika/lims/docs/ContactUser.rst bika/lims/docs/IDServer.rst bika/lims/idserver.py
senaite#2311) * WIP: Fix ID Server to handle a flushed storage or existing IDs with the same Prefix * refactored code * Make tests work again * remove all manual counter corrections * Added flush route to Number Generator view * Added some code and comments for future improvements Conflicts: bika/lims/idserver.py bika/lims/numbergenerator.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the following: