Unable to select or deselect columns to be displayed in lists #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: CHANGES.rst
ramonski
reviewed
Nov 28, 2017
| self.columns[col]['toggle'] = True | ||
| else: | ||
| self.columns[col]['toggle'] = False | ||
| self.columns[col]['toggle'] = col in toggle_cols |
| :rtype: list of str | ||
| """ | ||
| # Get the toggle configuration from the cookie | ||
| cookie_toggle = self.request.get('toggle_cols', '{}') |
There was a problem hiding this comment.
Shouldn't be that value in self.request.cookies?
Reminder: We have to consolidate all the different places in the system where cookies get set, because these cookies make caching by Varnish impossible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
When the user do a right-click in lists header, a popup with the list of available columns for the current view is displayed. An ok symbol appears next to the items their columns are already displayed in the list. By using this popup list, the user can choose which columns must be displayed or not based on his/her preferences (this configuration is stored in a cookie). Nevertheless, the list always display the columns set by default, regardless of the configuration set by the user.
Linked issue: #360 Listing Tables: Columns not selectable/deselectable
Current behavior before PR
Lists always displays the columns set by default, regardless of the configuration set by the user.
Desired behavior after PR is merged
Lists displays the columns the current user selected by making use of the popup for selection/deselection of items.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.