Remove calls to deprecated function getService from AbstractAnalysis #417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Removes all calls to the deprecated function
getService
fromAbstractAnalysis
. This function was returning the Analysis Service from which an Analysis was created. After the architectural refactoring of Analysis, objects from typeAnalysis
acquire the values from the originalAnalysisService
without the need of maintaining this relationship (that had an overhead because of anHistoryAwareReferenceField
was required).getService
function was labelled asdeprecated
then and was returing the Analysis itself. With this Pull Request, the calls togetService
have been removed and are using the fields provided by theAnalysis
object itself.Current behavior before PR
Deprecation warnings because of the use of
getService
function in logs.Desired behavior after PR is merged
No deprecation warnings in logs because the function
getService
is no longer used in the basecode.--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.