Issue-444: Fix Sample points do not show the referenced sample types in view #453
Conversation
bika/lims/content/samplepoint.py
Outdated
| @@ -79,7 +77,7 @@ | |||
| allowed_types=('SampleType',), | |||
| vocabulary='SampleTypesVocabulary', | |||
| relationship='SamplePointSampleType', | |||
| widget=brw( | |||
| widget=ReferenceWidget( | |||
There was a problem hiding this comment.
bika.lims.browser.widgets.referencewidget.ReferenceWidget (https://github.com/senaite/bika.lims/blob/master/bika/lims/browser/widgets/referencewidget.py) provides the search overlay that, for instance, is used in SampleType's edit view for the selection of multiple Sample Points, as well as in a lot of different places (e.g. Add AR). I'd expect the same behavior in both places, and honestly, I like the search overlay more than the multiselection list....
Could we tweak our ReferenceWidget to fix this issue instead of using Products.Archetypes.public.ReferenceWidget?
There was a problem hiding this comment.
Good catch, actually I forgot about the edit capabilities of the referencewidget.
I'll fix bika.lims.browser.widgets.referencewidget.ReferenceWidget to handle the view case better for old-style references.
Description of the issue/feature this PR addresses
Linked issue: #444
Current behavior before PR
Sample point view did not display referenced sample types
Desired behavior after PR is merged
Sample point view shows referenced sample types
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.