Issue-408: Calculation referring to additional python module not triggered #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Dec 9, 2017
bika/lims/browser/calcs.py
Outdated
| # # Get the specs directly from the analysis. The getResultsRange | ||
| # # function already takes care about which are the specs to be used: | ||
| # # AR, client or lab. | ||
| # specs = analysis.getResultsRange() |
There was a problem hiding this comment.
Yes, you are right, this block of code is no longer used since we introduced format_numeric_result in L273 as per d553f0c#diff-bddafb05eeff20ad5a33aab50565cba2 . You can safely remove this block instead of commenting it.
As an adiditional note, the specs for each analysis are obtained during the analyses list rendering in bika.lims.browser.analyses.py#L758-L770.
In any case, seems evident to me this whole class needs to be refactored asap.
xispa
reviewed
Dec 9, 2017
| @@ -215,7 +212,7 @@ def calculate(self, uid=None): | |||
| 'context': self.context}, | |||
| {'mapping': mapping}) | |||
| # calculate | |||
| result = eval(formula) | |||
| result = eval(formula, calculation._getGlobals()) | |||
There was a problem hiding this comment.
This calculation._getGlobals() is a good trick!
xispa
approved these changes
Dec 11, 2017
ramonski
deleted the
bugfix/issue-408-calcluations-using-python-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Linked issue: #408
Current behavior before PR
Calculations using external Python modules failed to calculate
Desired behavior after PR is merged
Calculations using external python modules calculate correctly the results
--
I confirm I have tested this PR thoroughly and coded it according to PEP8 standards.