Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard visibility by roles #472

Merged
merged 13 commits into from
Dec 17, 2017

Conversation

Espurna
Copy link

@Espurna Espurna commented Dec 15, 2017

Description of the issue/feature this PR addresses

The labmanager will be able to configure the visibility of each panel on a user-role basis directly from the dashboard (configuration option embedded in each panel).

This PR should be accepted after #467

Current behavior before PR

All users have granted the same view permissions to dashboard panels.

Desired behavior after PR is merged

The labmanager will be able to configure the visibility of each panel on a user-role basis directly from the dashboard using a pack of checkboxes under each panel.

@xispa it needs some CSS please :)

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed traceback if upgrade step 1.1.8 was not run, some code redux and styling

@xispa xispa merged commit 2b09e84 into senaite:master Dec 17, 2017
@Espurna Espurna deleted the task/424-dashboard-panels-visibility branch January 3, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants