Inconsistences when applying Worksheet Templates #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
approved these changes
Dec 30, 2017
xispa
commented
Dec 31, 2017
| self.request['context_uid'] = self.context.UID() | ||
| self.context.addDuplicateAnalyses(src_slot, position) | ||
| self.context.addDuplicateAnalyses(src_slot) |
There was a problem hiding this comment.
@xispa reminder: revert this change, I was not aware that there is a selector in "Add Duplicate" to allow the user to choose the slot to use. That selector has the next available slot option selected by default instead of "new slot" option. If a WSTemplate is assigned to the WS, better to select the latter option as default.
|
Thanks @ramonski for your code improvements!. I will open another PR to fix the unresolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Applying Worksheet Template to a Worksheet had some inconsistences that have been fixed with this PR, along with the following issues:
Linked issues:
Current behavior before PR
Inconsistent behavior with duplicates, references, analyses when using Worksheet Templates.
Desired behavior after PR is merged
Consistent behavior with duplicates, references, analyses when using Worksheet Templates.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.