Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of Analyses Services is not properly filtered by state #516

Merged
merged 7 commits into from
Dec 30, 2017

Conversation

xispa
Copy link
Member

@xispa xispa commented Dec 29, 2017

Description of the issue/feature this PR addresses

Analyses Services are not properly filtered when filtering by "Dormant" or "All". The reason was that the logic that is responsible of rendering the items (through ajax call) when a category is expanded was not taking into account the review_state condition set to the current view, so it was always returning the items with inactive_state=active.

Linked issue: List of Analyses Services is not properly filtered by state #510

A part from the above, the action buttons (for 'standard' transitions, in this case: "Activate" and "Deactivate") were not rendered at the bottom of the list. The reason was the category_expand_handler js event (that is responsible of requesting the items to be rendered under the expanded category via ajax call) was not calling load_transitions().

Current behavior before PR

List of Analyses Services is not filtered by state and action buttons are not rendered at the bottom of the list when selecting an Analysis Service.

Desired behavior after PR is merged

List of Analyses Services are filtered by state and action buttons are rendered at the bottom of the list when selecting an Analysis Service.

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski merged commit 139e8b5 into senaite:master Dec 30, 2017
@xispa xispa deleted the i510 branch December 31, 2017 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants