List of Analyses Services is not properly filtered by state #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Analyses Services are not properly filtered when filtering by "Dormant" or "All". The reason was that the logic that is responsible of rendering the items (through ajax call) when a category is expanded was not taking into account the
review_state
condition set to the current view, so it was always returning the items withinactive_state=active
.Linked issue: List of Analyses Services is not properly filtered by state #510
A part from the above, the action buttons (for 'standard' transitions, in this case: "Activate" and "Deactivate") were not rendered at the bottom of the list. The reason was the
category_expand_handler
js event (that is responsible of requesting the items to be rendered under the expanded category via ajax call) was not callingload_transitions()
.Current behavior before PR
List of Analyses Services is not filtered by state and action buttons are not rendered at the bottom of the list when selecting an Analysis Service.
Desired behavior after PR is merged
List of Analyses Services are filtered by state and action buttons are rendered at the bottom of the list when selecting an Analysis Service.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.