Client Batch lists are empty #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
approved these changes
Jan 11, 2018
| # TODO This workaround is necessary? | ||
| date = full_obj.Schema().getField('BatchDate').get(obj) | ||
| if callable(date): | ||
| date = date() |
There was a problem hiding this comment.
Just inspected the code and BatchDate is a normal DateTimeField which should have the common Archetypes getters/setters:
DateTimeField(
'BatchDate',
required=False,
widget=DateTimeWidget(
label=_('Date'),
),
),🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
With this Pull Request, the Batches list from inside Client displays the Batches assigned to the current Client. The reason was the view was querying for
AnalysisRequestobjects againstbika_catalog, while Analysis Requests live in ' bika_catalog_analysisrequest_listing`.Linked issue: Client Batch lists are empty #548
Although this PR only addresses the above mentioned issue, this view needs to be improved in terms of performance still:
folderitemCurrent behavior before PR
No batches listed in Client > Batches
Desired behavior after PR is merged
Client Batches are displayed in Client > Batches
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.