BadRequest error when changing Calculation on Analysis Service #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
changed the title
|
I think that change is not right, because setting a mutable default argument (in this case the list) is a bad idea. A new list is created once when the function is defined, and the same list is used in each successive call. I would therefore recommend that we use the version from AR Add2 to calculate the dependencies: https://github.com/senaite/senaite.core/blob/master/bika/lims/browser/analysisrequest/add2.py#L519 |
|
Please see this article for details: http://docs.python-guide.org/en/latest/writing/gotchas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Linked issue: #597
Current behavior before PR
BadRequest Error thrown on AS listing
Desired behavior after PR is merged
No error on AS listing
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.