Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unicode queries in Client ReferenceWidgetVocabulary #606

Merged
merged 3 commits into from
Jan 25, 2018
Merged

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

Linked issue: #605

Current behavior before PR

Analysis Specification are not found in AR Add Form for Sample Types containing a unicode character, e.g. Ö

Desired behavior after PR is merged

Analysis Specification are found in AR Add Form for Sample Types containing a unicode character, e.g. Ö

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramonski , very well explained in the comments from #605 and well executed too.


import plone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace between these two imports. I suggest to remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so as well, but somehow isort is keeping always adding that blank line between those two...

@xispa xispa merged commit 3a31179 into master Jan 25, 2018
@xispa xispa deleted the i605 branch February 2, 2018 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants