-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to select the number of sample sticker copies for printing #618
Merged
xispa
merged 24 commits into
senaite:master
from
juangallostra:choose-sticker-number-to-print
Jan 31, 2018
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0c02c33
Add number of copies control
4674a75
Get the number of sticker copies from the template
056af87
Remove unnecessary variable definition
ed1c4e1
Correct typo
421e443
Implement POST action when number of copies changes and bind it to St…
f1a0697
Add logic for showing multiple copies of stickers, update post action…
c7b2d3c
Make sticker copies of the same sample go together (group stickers by…
93470ad
Add field in bika set up to set the default number of copies
44b2494
Class constructor and get default number of copies when first loading…
f3e615e
Corrections: 1- Get default number of copies when request is empty, e…
ccc587a
modify method to get number of copies
3205da1
Merge branch 'master' of https://github.com/senaite/bika.lims into ch…
1d986b8
Rename bika with senaite
c8f7656
Move super class constructor to the begining of the init method
20baa51
Fix typos and documentation
0afc800
Refactor logic of creating as many copies as stickers wanted into a n…
70e22f7
Documentation
bf21718
Remove update_sticker_copies function since reload function provides …
ac805ca
Bind a change in the number of copies to the reload function
6dd8801
Remove blank lines
10e1e6c
Render stickers only of items that have a valid item_id
a50cb45
Remove rendered_items variable from code since it is no longer used
372527d
Remove blank lines
99cad8a
Update Changes log
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to figure out about that
view.rendered_items
. I understand why you need to remove it, cause each time the functionnextItem
is called, the current item is added in thisview.rendered_items
list, preventing you to display a label for a given object more than once. The thing is that I am not sure for whatview.rendered_items
var is used other than this condition... Anyhow, add acondition
for at least check ifitem_id
is notNone
(note that indefine
attribute there is the possibility to set anone
value toitem_id
, which is something weird again...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xispa I also checked the use of
rendered_items
and agree in that it was only used in the check that I removed to be able to print more than one copy. I am then going to removerendered_items
from the code.