Display the Unit in Profile Analyses Listing #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
requested changes
Feb 15, 2018
| items[x]['allow_edit'] = ['Hidden', ] | ||
| items[x]['Hidden'] = ser.get('hidden', obj.getHidden()) | ||
|
|
||
| self.allow_edit = "LabManager" in roles or "Manager" in roles | ||
| self.categories.sort() |
There was a problem hiding this comment.
I think this self.categories.sort() does nothing here in before_render. Since we don't have an after_render function (that would be nice), the best option would be to add the folderitems function, call super and sort the categories thereafter. Is not elegant, I know, but at least the Analysis Categories will appear sorted alphabetically when "Categorize Analysis Services" is enabled. With this code, the categories will appear in the order the analyses are retrieved (by sortable_title) which is not bad, but is not consistent with the rest.
There was a problem hiding this comment.
good catch, thanks, I'll change that
xispa
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Linked issue: #656
Also refactored and PEP8'ified AnalysisProfileAnalysesView
Current behavior before PR
Unit is not displayed in Analyses Listing of Profiles
Desired behavior after PR is merged
Unit is displayed in Analyses Listing of Profiles
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.