Listings: Fix sort_on change on Show More click #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
approved these changes
Feb 20, 2018
xispa
added a commit
to xispa/senaite.core
that referenced
this pull request
Feb 20, 2018
ramonski
pushed a commit
that referenced
this pull request
Feb 21, 2018
* Fix #670 Traceback on automatic sticker printing in batch context * Ensure safe return (dest var) in bika_listing's submitTransition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Linked issue: #669
Current behavior before PR
The sort_on index changed on "Show More" click from
createdtoid. Duplicate items were shown.Desired behavior after PR is merged
The sort_on index does not change on "Show More" click and initially keeps the
createdvalue from the view.--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.