Aggregated list of analyses set to read-only #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct way to introduce analysis results is by using Worksheets. The introduction of results through this list is meaningless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Is totally meaningless to allow the user to introduce results in aggregated list of analyses. The introduction of results must be done through Worksheets or, alternatively through the Analysis Request' manage results view.
Apart from this functional consideration, allowing the introduction of results in aggregated list of analyses was causing a lot of problems because when "Show more" button was clicked, the js events responsible of managing things like instruments, methods, calculation or remarks balloon was not working properly.
With this PR, the remarks toggle button (balloon) is not rendered by js anymore. Rather is managed by the Analyses view and the template. The js is only responsible of the click event. In addition, some styling to remarks field has been added.
By default, remarks field is always displayed in read-only analyses that have remarks set. For analyses that are in edit mode, a balloon is displayed to toggle the field.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.