Refactored and improved client folder listing view #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
approved these changes
Feb 23, 2018
| 'Fax', ] | ||
| }, | ||
| self.icon = "{}/{}".format( | ||
| self.portal_url, "++resource++bika.lims.images/client_big.png") |
There was a problem hiding this comment.
You could use this function https://github.com/senaite/senaite.core/blob/master/bika/lims/utils/__init__.py#L797-L808
self.icon = get_image("client_big.png")| ("MemberDiscountApplies", { | ||
| "toggle": False, | ||
| "title": _("Member Discount")}), | ||
| )) |
There was a problem hiding this comment.
Thanks for toggling to False those geographical things ;)
| item["replace"]["EmailAddress"] = get_email_link(item["EmailAddress"]) | ||
| # translate True/FALSE values | ||
| item["replace"]["BulkDiscount"] = obj.getBulkDiscount() and _("Yes") or _("No") | ||
| item["replace"]["MemberDiscountApplies"] = obj.getMemberDiscountApplies() and _("Yes") or _("No") |
There was a problem hiding this comment.
Cool!. An "iconic" alternative could be:
img_url = get_image('ok.png')
item["replace"]["BulkDiscount"] = obj.getBulkDiscount() and img_icon or " "
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Improves the client folder listing view (Mainly PEP8 and folder-item improvement)
Current behavior before PR
Not all columns were selectable and correctly rendered
Desired behavior after PR is merged
All available columns are selectable and correctly rendered
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.