Fix worksheet count on dashboard when filtering by department #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2018 13:36
This is to make filtering by department work with worksheets catalog.
ramonski
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The functional modifications are in the files
v01_02_004.pyandworksheet_catalog.py. The changes indashboard.pyare only to follow PEP8 style guidelines.Description of the issue/feature this PR addresses
When filtering by department the worksheet count that is shown in the dashboard doesn't get updated accordingly. This an effect of the real issue, which is that it is not possible to query the worksheets catalog by department UID since
getDepartmentUIDsis not an index (KeywordIndex) of the catalog.Current behavior before PR
Filtering by department isn't working with worksheets.
Desired behavior after PR is merged
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.